add new feature for EC-RAG#2423
Merged
Merged
Conversation
Signed-off-by: Yongbozzz <yongbo.zhu@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces EC-RAG “knowledge base ↔ pipeline” decoupling, reworks UI flows to manage Knowledge Bases separately from Pipelines, and adds Kubernetes Helm deployment artifacts alongside various docs/test updates.
Changes:
- Refactors backend pipeline execution to retrieve from multiple active knowledge bases (KB-driven indexing; pipeline holds retriever/generator config).
- Reworks the UI Knowledge Base module (new create/edit/detail flows for “knowledge” vs “experience”), and simplifies pipeline editing steps accordingly.
- Adds Helm chart manifests/config and updates scripts/tests/docs to align with the new KB/pipeline model.
Reviewed changes
Copilot reviewed 73 out of 75 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/enum.ts | Removes kbadmin options from pipeline enums |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/UpdateDialog/index.ts | Drops NodeParser/Indexer steps from pipeline update dialog exports |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/UpdateDialog/Retriever.vue | Simplifies retriever config UI logic |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/UpdateDialog/NodeParser.vue | Removes pipeline NodeParser step (file deleted) |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/UpdateDialog/EditDialog.vue | Reduces pipeline edit steps to retriever/post/generator/active |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/UpdateDialog/CreateDialog.vue | Reduces pipeline create steps to 5 total |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/Table.vue | Formatting/import adjustments |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/DetailDrawer.vue | Removes NodeParser/Indexer detail sections |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/columnsList.ts | Simplifies columns (shows retriever/postProcessor by default) |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/index.vue | Adds knowledge-specific create/edit/detail UI + disables edit when active |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/index.ts | Re-exports new dialogs/drawer components |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/UpdateKBDialog/index.ts | New KB dialog step exports |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/UpdateKBDialog/enum.ts | New KB-only node parser/indexer enums |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/UpdateKBDialog/NodeParser.vue | New KB NodeParser step UI |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/UpdateKBDialog/Indexer.vue | New KB Indexer step UI w/ kbadmin handling |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/UpdateKBDialog/EditDialog.vue | New KB edit wizard modal |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/UpdateKBDialog/CreateDialog.vue | New KB create wizard modal |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/UpdateKBDialog/Basic.vue | New KB basic info step (origin vs kbadmin) |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/UpdateKBDialog/Activated.vue | New KB active toggle step |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/UpdateExperienceDialog.vue | New experience create/edit modal |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/UpdateDialog.vue | Removes old combined UpdateDialog (file deleted) |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/KnowledgeDetail.vue | Adds file pagination + uses new filemap API |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/DetailDrawer.vue | New KB configuration detail drawer |
| EdgeCraftRAG/ui/vue/src/theme/common.less | Minor formatting + adds (commented) horizontal-form-item deep block |
| EdgeCraftRAG/ui/vue/src/i18n/zh.ts | Adds KB UI strings and wording updates |
| EdgeCraftRAG/ui/vue/src/i18n/en.ts | Adds KB UI strings and wording updates |
| EdgeCraftRAG/ui/vue/src/auto-imports.d.ts | Regenerates auto-import typings formatting |
| EdgeCraftRAG/ui/vue/src/api/knowledgeBase/index.ts | Adds KB json/files APIs + kbadmin list params |
| EdgeCraftRAG/ui/vue/components.d.ts | Regenerates components typings |
| EdgeCraftRAG/tools/quick_start.sh | Renames env vars (TP/QUANTIZATION/ZE_AFFINITY_MASK) |
| EdgeCraftRAG/tests/test_pipeline_local_llm.json | Removes embedded node_parser/indexer config |
| EdgeCraftRAG/tests/test_pipeline_ipex_vllm.json | Removes embedded node_parser/indexer config |
| EdgeCraftRAG/tests/test_compose_vllm_on_arc_b60.sh | Switches “add data” to knowledge-base flow |
| EdgeCraftRAG/tests/test_compose_vllm_on_arc.sh | Switches “add data” to knowledge-base flow + TP |
| EdgeCraftRAG/tests/test_compose_on_arc.sh | Switches “add data” to knowledge-base flow |
| EdgeCraftRAG/tests/configs/test_pipeline_local_llm.json | Removes embedded node_parser/indexer config |
| EdgeCraftRAG/tests/configs/test_pipeline_ipex_vllm.json | Removes embedded node_parser/indexer config |
| EdgeCraftRAG/tests/configs/test_kb.json | Adds KB config used by tests |
| EdgeCraftRAG/tests/configs/test_data.json | Removes old data payload (file deleted) |
| EdgeCraftRAG/tests/common.sh | Adds validate_knowledge helper and common vars |
| EdgeCraftRAG/kubernetes/helm/values.yaml | New Helm values for stack |
| EdgeCraftRAG/kubernetes/helm/templates/service-llm-serving-xpu.yaml | New Service for vLLM daemonset |
| EdgeCraftRAG/kubernetes/helm/templates/service-edgecraftrag-ui.yaml | New UI NodePort service |
| EdgeCraftRAG/kubernetes/helm/templates/service-edgecraftrag-server.yaml | New pipeline server service |
| EdgeCraftRAG/kubernetes/helm/templates/service-ecrag.yaml | New mega service |
| EdgeCraftRAG/kubernetes/helm/templates/deployment-edgecraftrag-ui.yaml | New UI deployment |
| EdgeCraftRAG/kubernetes/helm/templates/deployment-ecrag.yaml | New ecrag deployment |
| EdgeCraftRAG/kubernetes/helm/templates/daemonset-llm-serving-xpu.yaml | New vLLM daemonset |
| EdgeCraftRAG/kubernetes/helm/templates/daemonset-edgecraftrag-server.yaml | New server daemonset |
| EdgeCraftRAG/kubernetes/helm/templates/configmap-env.yaml | New ConfigMap for env wiring |
| EdgeCraftRAG/kubernetes/helm/README_zh.md | New Helm deployment doc (ZH) |
| EdgeCraftRAG/kubernetes/helm/README.md | New Helm deployment doc (EN) |
| EdgeCraftRAG/kubernetes/helm/Chart.yaml | New Helm chart metadata |
| EdgeCraftRAG/edgecraftrag/controllers/pipelinemgr.py | Activates pipeline using active KB list; removes node/index cache logic |
| EdgeCraftRAG/edgecraftrag/controllers/knowledge_basemgr.py | Supports multiple active KBs + stores origin_json |
| EdgeCraftRAG/edgecraftrag/controllers/filemgr.py | Switches file operations to take file_path |
| EdgeCraftRAG/edgecraftrag/config_repository.py | Persists KB config from stored KB json |
| EdgeCraftRAG/edgecraftrag/components/retriever.py | Simplifies KBadmin retriever; BM25 guard for milvus |
| EdgeCraftRAG/edgecraftrag/components/pipeline.py | Stores retriever config + builds retrievers per active KB |
| EdgeCraftRAG/edgecraftrag/components/knowledge_base.py | Moves node_parser/indexer into Knowledge; tracks nodes and origin_json |
| EdgeCraftRAG/edgecraftrag/components/indexer.py | Adjusts collection naming; moves kbadmin milvus mapping here |
| EdgeCraftRAG/edgecraftrag/api_schema.py | Moves node_parser/indexer from PipelineCreateIn to KnowledgeBaseCreateIn |
| EdgeCraftRAG/edgecraftrag/api/v1/system.py | Updates OpenVINO import style |
| EdgeCraftRAG/edgecraftrag/api/v1/pipeline.py | Pipeline update now only stores retriever config + activation wiring |
| EdgeCraftRAG/edgecraftrag/api/v1/data.py | Removes /v1/data ingestion; nodes now KB-driven |
| EdgeCraftRAG/edgecraftrag/api/v1/chatqna.py | Uses list of active KBs in request.user |
| EdgeCraftRAG/edgecraftrag/api/v1/agent.py | Updates activation wiring for KB list |
| EdgeCraftRAG/edgecraftrag/VERSION | Bumps version to 26.03-Dev |
| EdgeCraftRAG/docs/Quick_Start_Guide_Zh.md | Removes old quick start doc (file deleted) |
| EdgeCraftRAG/docs/API_Guide.md | Updates KB API examples to new flow |
| EdgeCraftRAG/docker_compose/intel/gpu/arc/set_env.sh | Renames env vars (TP/QUANTIZATION) |
| EdgeCraftRAG/docker_compose/intel/gpu/arc/compose.yaml | Renames env vars mapping for vLLM container |
| EdgeCraftRAG/docker_compose/intel/gpu/arc/README_zh.md | Adds expanded Arc deployment guide |
| EdgeCraftRAG/docker_compose/intel/gpu/arc/README.md | Updates Arc deployment guide + adds ZH link |
| EdgeCraftRAG/Dockerfile.server | Changes PPA suite from plucky → questing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Yongbozzz <yongbo.zhu@intel.com>
Signed-off-by: Yongbozzz <yongbo.zhu@intel.com>
d430814 to
75b2ad3
Compare
Signed-off-by: Yongbozzz <yongbo.zhu@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Yongbozzz <yongbo.zhu@intel.com>
lvliang-intel
approved these changes
Mar 12, 2026
ZePan110
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add new feature for EC-RAG :
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies